Remove deprecated build parameter NODE_LABEL

[AdamBrousseau]

There is a build parameter for NODE_LABEL which I believe is no longer used as it seems to have been replaced with the equivalent one in the json BUILD_CONFIGURATION. From my testing it appears we can just clean this up as it isn't used. I'm happy to do the PR if there are no concerns but I don't have the rights to reconfig the jobs on the Adopt CI.

[sxa]

To be honest, given that it seems to disappear without warning when I try to run jobs, if it really isn't required I'd be more than happy to see it go :-)

[M-Davies]

Copying this from the dup issue I raised -> adoptium/temurin-build#2378
Intially raised by Stewart on Slack -> https://adoptopenjdk.slack.com/archives/C09NW3L2J/p1610466417493400

There's a NODE_LABEL parameter to the individual build jobs and also a NODE_LABEL value in the BUILD_CONFIGURATION JSON. - two questions

• Why do we need two (I'm guessing the separate one is needed for the scheduling? But then does it need to be in the build config? @johnoliver I'm hoping you could answer this one regarding this history of having both?
• Sometimes if I go in and re-run a build job the NODE_LABEL parameter looks to be populated OK but after I submit it it seems to disappear and not schedule, re-running again copying the value from BUILD_CONFIGURATION seems to work ok. Is there a reason for this (weird jenkins quirk?) and does anyone know of a workaround? I (@M-Davies) suspect it's due to how we generate and instantiate this parameter but I can't be sure

[AdamBrousseau]

I recently found this line too which I think is where this is coming from. From what I can tell, it forces the very beginning of the pipeline (lightweight checkout) onto a matching node. Normally this would happen on master. Either way it is a lightweight executor (doesn't use an executor slot). The NODE_LABEL in the json appears to be the one that picks the compile machine. IMO I don't think it needs to be there.

['$class': 'LabelParameterValue', name: 'NODE_LABEL', label: "${nodeFilter}"],

[sxa]

@johnoliver Can you give some input into this please? Is there any reason to retain the second NODE_LABEL which appears to just cause confusion?