Add Smoke Tests

[sophia-guo]

Close #83

Signed-off-by: Sophia Guo [email protected]

[github-actions]

Thank you for creating a pull request!
In order to run the pipeline tests I require an admin to post the following comment: run tests

[sophia-guo]

run tests

[adoptopenjdk-github-bot]

🟠 PR TESTER RESULT 🟠

❎ Some pipelines failed or the job was aborted! ❎
See the pipeline-build-check below for more information...

[sophia-guo]

run tests

[adoptopenjdk-github-bot]

🟠 PR TESTER RESULT 🟠

❎ Some pipelines failed or the job was aborted! ❎
See the pipeline-build-check below for more information...

[sophia-guo]

run tests

[adoptopenjdk-github-bot]

🟠 PR TESTER RESULT 🟠

❎ Some pipelines failed or the job was aborted! ❎
See the pipeline-build-check below for more information...

[sophia-guo]

run tests

[adoptopenjdk-github-bot]

🟢 PR TESTER RESULT 🟢

✅ All pipelines passed! ✅

[sophia-guo]

run tests

[adoptopenjdk-github-bot]

🟠 PR TESTER RESULT 🟠

❎ Some pipelines failed or the job was aborted! ❎
See the pipeline-build-check below for more information...

[sophia-guo]

run tests

[adoptopenjdk-github-bot]

🟢 PR TESTER RESULT 🟢

✅ All pipelines passed! ✅

[M-Davies]

@sophia-guo Is this ready for review now?

[sophia-guo]

run tests

[smlambert]

@M-Davies - are you good to proceed with this PR? It shows you as requesting a change, have all your requests been met?

[M-Davies]

@M-Davies - are you good to proceed with this PR? It shows you as requesting a change, have all your requests been met?

Still looking for some clarification for this

[smlambert]

IMHO, enableTests could just as well be called enableAQATests. The smoke tests are different, they are not part of the AQA tests, they are checking the tarball was built with the correct features enabled, and correct version information and metadata has been be produced. There could then be a enableSmokeTests option, because one may want smoke tests but not AQA tests...

I don't want us to get bogged down in this however, it is more important that we are running these then whether some person kicking off build pipelines is monkeying with settings.

So the proposal to

if (enableTests) {
    runSmokeTests()
    if (buildConfig.TEST_LIST.size() > 0) {
        try {

is fine by me.

[sophia-guo]

@M-Davies updated.

[M-Davies]

run tests (assuming the PR tester does not pick up any issues missed, I'll be happy to approve this)

[M-Davies]

PR tester is down due to the current jenkins instability. There's nothing I can see in the code that would indicate it would fail so I'm happy to approve this and submit a test pipeline after merge

[smlambert]

If you are ready to merge this @M-Davies please do so (I do not believe @sophia-guo has write permissions to this repo, so she would be unable to merge her own).

[M-Davies]

I believe @andrew-m-leonard is doing the m2 builds at the moment so I'll merge tomorrow morning when they are done

[gdams]

run tests

[gdams]

run tests

[gdams]

run tests

[adoptopenjdk-github-bot]

 PR TESTER RESULT 

❎ Some pipelines failed or the job was aborted! ❎
See the pipeline-build-check below for more information...

[M-Davies]

I would merge but it appears I do not have write access to this repo anymore since it was changed to adoptium :(

[smlambert]

@M-Davies - you are listed as a committer (https://projects.eclipse.org/proposals/eclipse-temurin) which means you should have write permissions, so please check your Eclipse profile (and make sure that your github ID is listed in it... you can see it in social media section when you click Edit profile).

[gdams]

Looks like it's there: https://projects.eclipse.org/user/15355

That is rather strange?

[M-Davies]

I'll try and sort it out on slack to avoid the spam here

[smlambert]

I've sent a note to emo team (& cc-ed @M-Davies ) - I think what happened is that Morgan was on the committer list for the Temurin project proposal, but not in the list for the actual project once the proposal was approved. Vague recollection of Wayne not receiving Morgan's email in time for project creation. It can and should be added now, and that is what is requested by the email to emo team.