Use dockerhost-rise-ubuntu2204-aarch64-1 host to run in QEMU for riscv64 #864

luhenry · 2023-12-20T15:18:30Z

No description provided.

The boards are just too limited at the moment. It only targets jdk17u, jdk19u, and jdk20u for now for lack of Ubuntu 20.04 compatible builds of jdk20u (for jdk21u) and jdk21u (for jdk22). Once we've some builds of jdk20u on Ubuntu 20.04, we can enable jdk21u. Next we can do jdk21u for jdk22.

…o riscv64-docker-images

github-actions · 2023-12-20T15:18:41Z

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

sxa

Probably not needed for pre-JDK21 but it won't do any harm. I /think/ this will work, but I'm happy to approve and we can look at fixing up later if there are any problems.

luhenry · 2023-12-20T18:53:32Z

@sxa how can we get it merged?

sxa · 2023-12-20T19:07:46Z

@sxa how can we get it merged?

As per the message from github it needs two reviewers. I have approved it already, but you need a second.

smlambert

👍

sxa

Oh hang on - just noticed before merging that there are linter failures - those will need to be addressed first
EDIT: It's missing the comma at the end of the crossCompile line.

luhenry · 2023-12-21T12:08:18Z

pipelines/jobs/configurations/jdk21u_pipeline_config.groovy

@@ -166,6 +166,9 @@ class Config21 {
        riscv64Linux      :  [
                os                  : 'linux',
                arch                : 'riscv64',
+                // crossCompile        : 'dockerhost-rise-ubuntu2204-aarch64-1',


@sxa can we actually enable this one as well? (regarding the bootjdk issue)

Since we're using 21 to bootstrap 21 on RISC-V then yeah as soon as we've got a suitable boot JDK that can be used then we can enable this.
On my "static" containerized build environemnts on my machines I've manually installed the 21.0.1+12.1 JDK and symlinked to /usr/lib/jvm/jdk-21 - we should set up the playbooks to do that.

luhenry · 2023-12-21T12:08:38Z

pipelines/jobs/configurations/jdk22_pipeline_config.groovy

@@ -145,6 +145,9 @@ class Config22 {
        riscv64Linux      :  [
                os                  : 'linux',
                arch                : 'riscv64',
+                // crossCompile        : 'dockerhost-rise-ubuntu2204-aarch64-1',


@sxa same as jdk21u

sxa · 2023-12-21T13:32:46Z

Yeah once we get the boot JDK in then we can definitely add the other two pipelines.
I'm not quite sure why the Test / Groovy check is failing just now though ...

EDIT: Tests are failng downloading testng from jenkins-ci.org:

   > Could not find org.testng:testng:7.2.0.
     Searched in the following locations:
       - https://repo.maven.apache.org/maven2/org/testng/testng/7.2.0/testng-7.2.0.pom
       - https://repo.jenkins-ci.org/releases/org/testng/testng/7.2.0/testng-7.2.0.pom
       - https://repo.jenkins-ci.org/public/org/testng/testng/7.2.0/testng-7.2.0.pom

Since this is nothing to do with the PR I'm going to ignore that for now - it looks like the 7.2.0 may have been removed as it does not exist in any of those repositories at the time of writing this. We'll need a separate issue to cover that.

sxa

I'm going to merge this for 17 just now so we can get it tested in production - we can look at enabling in a subsequent PR for 21+ (Noting that JDK23 will fail until we fix the boot JDK download issue)

…v64 (adoptium#864) * Use cross-compilation with Docker for riscv64 The boards are just too limited at the moment. It only targets jdk17u, jdk19u, and jdk20u for now for lack of Ubuntu 20.04 compatible builds of jdk20u (for jdk21u) and jdk21u (for jdk22). Once we've some builds of jdk20u on Ubuntu 20.04, we can enable jdk21u. Next we can do jdk21u for jdk22. * Use dockerhost-rise-ubuntu2204-aarch64-1 host to run in QEMU for riscv64 * Fix missing comma

luhenry added 4 commits November 9, 2023 17:11

Merge branch 'master' of github.com:adoptium/ci-jenkins-pipelines int…

5b3774f

…o riscv64-docker-images

Merge branch 'master' of github.com:adoptium/ci-jenkins-pipelines int…

ac8e8a0

…o riscv64-docker-images

Use dockerhost-rise-ubuntu2204-aarch64-1 host to run in QEMU for riscv64

1a7c54c

luhenry mentioned this pull request Dec 20, 2023

RISC-V build plan adoptium/temurin-build#3591

Open

7 tasks

sxa approved these changes Dec 20, 2023

View reviewed changes

github-actions bot added aarch docker labels Dec 20, 2023

smlambert approved these changes Dec 20, 2023

View reviewed changes

sxa approved these changes Dec 21, 2023

View reviewed changes

sxa requested changes Dec 21, 2023

View reviewed changes

Fix missing comma

d6467d2

luhenry commented Dec 21, 2023

View reviewed changes

sxa approved these changes Dec 21, 2023

View reviewed changes

sxa merged commit bb28b46 into adoptium:master Dec 21, 2023
5 of 7 checks passed

sxa mentioned this pull request Dec 21, 2023

PR checks failing as testng-7.2.0.jar no longer exists on repo.jenkins-ci.org #866

Open

luhenry mentioned this pull request Dec 21, 2023

Use Docker container for riscv64 #836

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use dockerhost-rise-ubuntu2204-aarch64-1 host to run in QEMU for riscv64 #864

Use dockerhost-rise-ubuntu2204-aarch64-1 host to run in QEMU for riscv64 #864

luhenry commented Dec 20, 2023

github-actions bot commented Dec 20, 2023

sxa left a comment

luhenry commented Dec 20, 2023 •

edited

Loading

sxa commented Dec 20, 2023

smlambert left a comment

sxa left a comment •

edited

Loading

luhenry Dec 21, 2023 •

edited

Loading

sxa Dec 21, 2023

luhenry Dec 21, 2023

sxa commented Dec 21, 2023 •

edited

Loading

sxa left a comment

Use dockerhost-rise-ubuntu2204-aarch64-1 host to run in QEMU for riscv64 #864

Use dockerhost-rise-ubuntu2204-aarch64-1 host to run in QEMU for riscv64 #864

Conversation

luhenry commented Dec 20, 2023

github-actions bot commented Dec 20, 2023

Thank you for creating a pull request!

Code Quality and Contributing Guidelines

Tests

sxa left a comment

Choose a reason for hiding this comment

luhenry commented Dec 20, 2023 • edited Loading

sxa commented Dec 20, 2023

smlambert left a comment

Choose a reason for hiding this comment

sxa left a comment • edited Loading

Choose a reason for hiding this comment

luhenry Dec 21, 2023 • edited Loading

Choose a reason for hiding this comment

sxa Dec 21, 2023

Choose a reason for hiding this comment

luhenry Dec 21, 2023

Choose a reason for hiding this comment

sxa commented Dec 21, 2023 • edited Loading

sxa left a comment

Choose a reason for hiding this comment

luhenry commented Dec 20, 2023 •

edited

Loading

sxa left a comment •

edited

Loading

luhenry Dec 21, 2023 •

edited

Loading

sxa commented Dec 21, 2023 •

edited

Loading