Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

winPB: Update OpenSSL to 1.1.1i and streamline updates #1753

Merged
merged 1 commit into from
Dec 10, 2020

Conversation

sxa
Copy link
Member

@sxa sxa commented Dec 9, 2020

Ref: #1752

Signed-off-by: Stewart X Addison [email protected]

Checklist
  • commit message has one of the standard prefixes
  • FAQ.md updated if appropriate
  • other documentation is changed or added (if applicable)
  • playbook changes run through VPC or QPC (if you have access)
  • inventory changes, ensure bastillion is updated accordingly

@sxa sxa added this to the December 2020 milestone Dec 9, 2020
@sxa sxa requested a review from Willsparker December 9, 2020 12:11
@sxa sxa self-assigned this Dec 9, 2020
@karianna
Copy link
Contributor

karianna commented Dec 9, 2020

looks good but your linter doesn't like you :-)

@sxa sxa force-pushed the openssl111i branch 3 times, most recently from 927a0a2 to 7b4417b Compare December 9, 2020 13:04
@sxa
Copy link
Member Author

sxa commented Dec 9, 2020

looks good but your linter doesn't like you :-)

The role didn't like me either - for some reason it doesn't like the checksum being a variable so I'm backing that out unti lsomeone who has more time looks at fixing it but at leasdt the docs are in there now :-)

@sxa
Copy link
Member Author

sxa commented Dec 9, 2020

Linter issues resolved - verifying on build-ibmcloud-win2012r2-x64-2 through AWX then will set ready for review before deploying elsewhere

@sxa
Copy link
Member Author

sxa commented Dec 9, 2020

Seems to be running through ok on AWX - final validation at https://ci.adoptopenjdk.net/view/Tooling/job/VagrantPlaybookCheck/OS=Win2012,label=vagrant/962 along with the openjdk-build change

Copy link
Contributor

@Willsparker Willsparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, on the condition it passes VPC - the change to using a variable is much appreciated 😅

@Willsparker
Copy link
Contributor

ref: #1752

@sxa sxa marked this pull request as ready for review December 10, 2020 10:16
@sxa
Copy link
Member Author

sxa commented Dec 10, 2020

JDK8 J9 build with VS2013 looks ok, so I'd hope the others are good too.

There was one glitch during the playbook installation but this looks like a connection glitch to the machine (as you can see below it happened about a second after attempting the connection, so assumed to be unrelated to the playbook).

21:55:44 TASK [Download OpenSSL-1.1.1i] *************************************************
21:56:05 [WARNING]: ERROR DURING WINRM SEND INPUT - attempting to recover:
21:56:05 WinRMOperationTimeoutError
21:56:19 changed: [127.0.0.1]
21:56:19 

@Willsparker
Copy link
Contributor

Can't say I've ever seen that connection drop issue before! Curious. But yeah, fine with me if it worked with JDK8/J9_VS2013, then if it didn't work with any other platform, it wouldn't be an issue with the playbook, I don't think :-)

@sxa sxa merged commit 9a9a587 into adoptium:master Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants