-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
winPB: Update OpenSSL to 1.1.1i and streamline updates #1753
Conversation
looks good but your linter doesn't like you :-) |
927a0a2
to
7b4417b
Compare
The role didn't like me either - for some reason it doesn't like the checksum being a variable so I'm backing that out unti lsomeone who has more time looks at fixing it but at leasdt the docs are in there now :-) |
Linter issues resolved - verifying on build-ibmcloud-win2012r2-x64-2 through AWX then will set ready for review before deploying elsewhere |
Signed-off-by: Stewart X Addison <[email protected]>
Seems to be running through ok on AWX - final validation at https://ci.adoptopenjdk.net/view/Tooling/job/VagrantPlaybookCheck/OS=Win2012,label=vagrant/962 along with the openjdk-build change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, on the condition it passes VPC - the change to using a variable is much appreciated 😅
ref: #1752 |
JDK8 J9 build with VS2013 looks ok, so I'd hope the others are good too. There was one glitch during the playbook installation but this looks like a connection glitch to the machine (as you can see below it happened about a second after attempting the connection, so assumed to be unrelated to the playbook).
|
Can't say I've ever seen that connection drop issue before! Curious. But yeah, fine with me if it worked with JDK8/J9_VS2013, then if it didn't work with any other platform, it wouldn't be an issue with the playbook, I don't think :-) |
Ref: #1752
Signed-off-by: Stewart X Addison [email protected]
Checklist