Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inv: Correct Docker marist s390x node name #1806

Merged
merged 1 commit into from
Jan 14, 2021
Merged

Conversation

Willsparker
Copy link
Contributor

ref: #1716 (comment)

  • inventory changes, ensure bastillion is updated accordingly

Just some mistakes I noticed whilst going through the list of machines that need to be added to Nagios. As these are inconsistent with the node names in Jenkins, my Nagios check (#1717) is unable to find them. I opted for changing the inventory entry as this is easier than renaming the node in Jenkins :-)

@Willsparker Willsparker added the bug label Jan 6, 2021
@Willsparker Willsparker added this to the January 2021 milestone Jan 6, 2021
@Willsparker Willsparker self-assigned this Jan 6, 2021
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change to add the l onto a subset of the arm systems makes the naming inconsistent as many are still left as armv8 / armv7, so I would suggest we need to change the definitions elsewhere.

@Willsparker
Copy link
Contributor Author

I'll take that out - we should probably change it in Jenkins then :-)

@Willsparker Willsparker changed the title inv: Correct Node name mistakes inv: Correct Build-marist s390x node name Jan 6, 2021
Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@karianna karianna requested a review from sxa January 6, 2021 14:44
@Willsparker Willsparker changed the title inv: Correct Build-marist s390x node name inv: Correct Docker marist s390x node name Jan 14, 2021
@sxa sxa merged commit bae301d into adoptium:master Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants