unixPb: Install shared-mime-info on fedora docker static containers #2679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sxa
requested changes
Aug 1, 2022
Haroon-Khel
changed the title
sxa
requested changes
Aug 10, 2022
There was a problem hiding this comment.
@Haroon-Khel You've changed the PR title but not the commit message which is the important bit since that shows in the commit history in the repository.
…ructure into mime.package
|
Changed the commit message, but my git cli wouldn't push without making an unnecessary merge. Should be fine though (in hindsight I should have force pushed) |
sxa
approved these changes
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #2631 (comment)
The jdk8 test java/nio/file/Files/probeContentType/Basic.java seems to pass on fedora only when this package is installed
Tested on test-docker-fedora36-x64-1
Before install
https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/5225/
After install
https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/5226/