-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker: Fix docker repo for s390x rhel #2707
Conversation
Have there been new changes to the Linter?
I don't see how these are about my changes |
looks like the last green linter run was on 6.4.0, yours is on 6.5.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this ok for RHEL8 too? Do we need a separate entry here now given that this change pretty much makes it identical to the x64 entry?
In that case I suggest raising a separate issue to resolve the linter problems showing after the update |
@sxa right now we only install it on rhel/centos 7 infrastructure/ansible/playbooks/AdoptOpenJDK_Unix_Playbook/roles/Docker/tasks/main.yml Line 27 in b39f70b
|
Our 3 rhel8 machines, all test, do not have docker installed. We have a centos8 machine build-equinix-centos8-armv8-1, but I cant ssh into it ( I can work on getting our playbooks to install docker on rhel/centos8 after this pr is merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our 3 rhel8 machines, all test, do not have docker installed. We have a centos8 machine build-equinix-centos8-armv8-1, but I cant ssh into it (
Permission denied (publickey)
) to check if we have docker on it.I can work on getting our playbooks to install docker on rhel/centos8 after this pr is merged
To be fair, CentOS8 is now EOL so that doesn't matter so much, but it's worth checking it on the Marist RHEL8 system later, but I agree that doesn't need to be part of this PR if it's not causing a problem for the deployments on there. So on that basis I approve, but please create an issue for merging this with the x64 version and seeing if we can install docker on RHEL8 too.
(I can give you access to the equinix Cent8 box if you want it, but I was intending to reinstall it with a supported OS and never use it again as-is)
ref #2700
The former repo does not allow for docker to be installed onto our s390x rhel7 systems. Changing it to https://download.docker.com/linux/rhel/7/s390x/stable/ seems to work
https://awx2.adoptopenjdk.net/#/jobs/playbook/202?job_search=page_size:20;order_by:-finished;not__launch_type:sync