Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dragonwell build does not validate existing workspace correctly #2349

Closed
andrew-m-leonard opened this issue Jan 4, 2021 · 0 comments · Fixed by #2352
Closed

dragonwell build does not validate existing workspace correctly #2349

andrew-m-leonard opened this issue Jan 4, 2021 · 0 comments · Fixed by #2352
Assignees
@andrew-m-leonard
Labels
buildbreak High priority issues that cause build breaks in jenkins or build scripts dragonwell/alibaba Issues that are enhancements or bugs raised against the Dragonwell JVM of the Alibaba project jenkins Issues that enhance or fix our jenkins server
Milestone
January 2021

Comments

@andrew-m-leonard
Copy link
Contributor 

23:32:32  origin	https://github.com/adoptopenjdk/openjdk-jdk8u.git (fetch)
23:32:32  origin	https://github.com/adoptopenjdk/openjdk-jdk8u.git (push)
23:32:32  jdk11
23:32:32  origin	https://github.com/adoptopenjdk/openjdk-jdk8u.git (fetch)
23:32:32  Resetting the git openjdk source repository at /cygdrive/c/Jenkins/workspace/workspace/build/src in 10 seconds...
23:32:43  Pulling latest changes from git openjdk source repository
23:32:43  checkoutRequiredCodeToBuild:
23:32:43    workspace = /cygdrive/c/Jenkins/workspace/workspace/./build//src
23:32:43    BUILD_VARIANT = dragonwell
23:32:43    TAG = 
23:32:43    BRANCH = master
23:32:43  Fetching origin
...
23:33:34  Pulling latest tags and getting the latest update version using git fetch -q --tags --depth=1
23:33:34  NOTE: This can take quite some time!  Please be patient
23:33:43  From /cygdrive/c/Jenkins/workspace/workspace/./build//src
23:33:43   * branch                  HEAD       -> FETCH_HEAD
23:33:43  WARNING: Failed to identify latest tag in the repository
23:33:43  Unable to detect git tag, exiting...

Problem here: https://github.com/AdoptOpenJDK/openjdk-build/blob/8e1864e29c88ea013483590f34a9d160c832aeae/sbin/prepareWorkspace.sh#L58
is not validating it is the correct https://github.com/alibaba/dragonwell11.git repo...
@andrew-m-leonard andrew-m-leonard added the buildbreak High priority issues that cause build breaks in jenkins or build scripts label Jan 4, 2021
@andrew-m-leonard andrew-m-leonard self-assigned this Jan 4, 2021
@M-Davies M-Davies added jenkins Issues that enhance or fix our jenkins server dragonwell/alibaba Issues that are enhancements or bugs raised against the Dragonwell JVM of the Alibaba project labels Jan 5, 2021
@karianna karianna added this to the January 2021 milestone Jan 5, 2021
@karianna karianna linked a pull request Jan 5, 2021 that will close this issue
Ensure dragonwell build validates git repo correctly #2352
Merged
@karianna karianna closed this as completed Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrew-m-leonard andrew-m-leonard

Labels
buildbreak High priority issues that cause build breaks in jenkins or build scripts dragonwell/alibaba Issues that are enhancements or bugs raised against the Dragonwell JVM of the Alibaba project jenkins Issues that enhance or fix our jenkins server
Projects
None yet
Milestone
January 2021
Development

Successfully merging a pull request may close this issue.

Ensure dragonwell build validates git repo correctly andrew-m-leonard/openjdk-build
3 participants
@karianna @M-Davies @andrew-m-leonard