Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure dragonwell build validates git repo correctly #2352

Merged
merged 1 commit into from
Jan 5, 2021
Merged

Ensure dragonwell build validates git repo correctly #2352

merged 1 commit into from
Jan 5, 2021

Conversation

andrew-m-leonard
Copy link
Contributor

Signed-off-by: Andrew Leonard [email protected]

sxa
sxa approved these changes Jan 5, 2021
View reviewed changes
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tentative approval :-) Let's make sure we do a test run to validate that it works before the nightlies run

@andrew-m-leonard andrew-m-leonard merged commit 18715f8 into adoptium:master Jan 5, 2021
@andrew-m-leonard
Copy link
Contributor Author

Test build: https://ci.adoptopenjdk.net/job/build-scripts/job/jobs/job/jdk11u/job/jdk11u-windows-x64-dragonwell/27/

@M-Davies M-Davies added bug Issues that are problems in the code as reported by the community dragonwell/alibaba Issues that are enhancements or bugs raised against the Dragonwell JVM of the Alibaba project labels Jan 5, 2021
@karianna karianna linked an issue Jan 5, 2021 that may be closed by this pull request
dragonwell build does not validate existing workspace correctly #2349
Closed
@karianna karianna added this to the January 2021 milestone Jan 5, 2021
@sxa sxa mentioned this pull request Jan 13, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sxa sxa sxa approved these changes

@gdams gdams gdams approved these changes

@karianna karianna Awaiting requested review from karianna

Assignees
No one assigned
Labels
bug Issues that are problems in the code as reported by the community dragonwell/alibaba Issues that are enhancements or bugs raised against the Dragonwell JVM of the Alibaba project
Projects
None yet
Milestone
January 2021
Development

Successfully merging this pull request may close these issues.

dragonwell build does not validate existing workspace correctly
5 participants
@andrew-m-leonard @sxa @gdams @karianna @M-Davies