Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move @noinline into generated overloads once Julia 1.6 compatibility is dropped #130

Closed
adrhill opened this issue Jun 19, 2024 · 0 comments · Fixed by #205
Closed

Move @noinline into generated overloads once Julia 1.6 compatibility is dropped #130

adrhill opened this issue Jun 19, 2024 · 0 comments · Fixed by #205

Comments

@adrhill
Copy link
Owner

adrhill commented Jun 19, 2024

I attempted this in #129 but ran into issues on Julia 1.6:

ERROR: LoadError: LoadError: LoadError: (SparseConnectivityTracer).connectivity_tracer_1_to_1(tx, is_infl_arg1_zero) is not a function expression

This should be revisited once a new LTS is released as it could speed up array overloads (#115).
@adrhill adrhill changed the title Move @noinline into generated overloads once 1.6 is dropped Move @noinline into generated overloads once Julia 1.6 compatibility is dropped Jun 19, 2024
This was referenced Oct 9, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move @noinline into code generation utilities adrhill/SparseConnectivityTracer.jl
1 participant
@adrhill