Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build(example)/Update @nestjs/testing dependency in package.json for compatibility #24

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

KantaHasegawa
Copy link
Contributor

@KantaHasegawa KantaHasegawa commented Feb 29, 2024

Thank you for providing me with a great library!
A broken dependency in the example directory has been corrected.

@nestjs/testing ^8.2.6 ^9.2.0

node version v21.6.2

npm i

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: [email protected]
npm ERR! Found: @nestjs/[email protected]
npm ERR! node_modules/@nestjs/common
npm ERR!   @nestjs/common@"^9.2.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer @nestjs/common@"^8.0.0" from @nestjs/[email protected]
npm ERR! node_modules/@nestjs/testing
npm ERR!   dev @nestjs/testing@"^8.2.6" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR!
npm ERR! For a full report see:
npm ERR! /Users/kanta/.npm/_logs/2024-02-29T09_20_50_928Z-eresolve-report.txt

npm ERR! A complete log of this run can be found in: /Users/kanta/.npm/_logs/2024-02-29T09_20_50_928Z-debug-0.log

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@KantaHasegawa KantaHasegawa changed the title Build(exapmle)/Update @nestjs/testing dependency in package.json for compatibility Build(example)/Update @nestjs/testing dependency in package.json for compatibility Feb 29, 2024
@KantaHasegawa KantaHasegawa marked this pull request as draft February 29, 2024 09:39
@KantaHasegawa KantaHasegawa marked this pull request as ready for review February 29, 2024 09:45
@KantaHasegawa
Copy link
Contributor Author

@adrianbrs

@adrianbrs adrianbrs added dependencies Pull requests that update a dependency file type: deps Pull requests that update a dependency file type: example and removed dependencies Pull requests that update a dependency file labels Sep 30, 2024
@adrianbrs adrianbrs merged commit 35b1fbe into adrianbrs:main Sep 30, 2024
9 checks passed
@adrianbrs
Copy link
Owner

Thanks @KantaHasegawa! Sorry for the long delay.
I'll definitely be paying more attention to this package from now on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: deps Pull requests that update a dependency file type: example
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants