ignoreDefaultProps should work for forwardRef components as well #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #165 +/- ##
=======================================
Coverage 97.19% 97.19%
=======================================
Files 6 6
Lines 107 107
Branches 41 41
=======================================
Hits 104 104
Misses 3 3
Continue to review full report at Codecov.
|
|
@bradbarrow Hi! Thank you very much for your contribution, this PR looks really good, I'll merge it now and publish a new version today. |
|
It's published in [email protected] 🎉 |
|
Thanks for the quick turn around @adriantoine :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue I found when I wrapped a component in
React.forwardRefand it'sdefaultPropsappeared in my snapshots despite me havingignoreDefaultPropsset.To handle this, I've added the
react-islibrary which was explicitly developed by the React JS team to handle this sort of type checking more robustly.I've written tests and ensured that existing tests don't fail.