Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using $GITHUB_ACTION_PATH env var instead of ${{ github.action_path }} context #7

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

way-dave
Copy link
Contributor

When running in a container, ${{ github.action_path }} resolves to the wrong location:

python3: can't open file '/home/runner/work/_actions/advanced-security/filter-sarif/v1/filter_sarif.py': [Errno 2] No such file or directory

Using the environmental variable works.

According to actions/runner#716, this change should not be needed. But it is! 🤷

@jstsddg
Copy link

jstsddg commented Apr 1, 2023

Thanks for the fix! My team is having the same issue, can this PR somehow be pushed forward?
/CC @zbazztian

@aegilops aegilops merged commit f3b8118 into advanced-security:main Apr 26, 2023
@way-dave
Copy link
Contributor Author

Thanks for the merge! When can we expect to see this available on the v1 tag?

@aegilops
Copy link
Collaborator

It's now on each of the v1.0.1, v1.0 and v1 tags

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants