matrix-sdk-crypto contains potential impersonation via room key forward responses
Moderate severity
GitHub Reviewed
Published
Sep 29, 2022
in
matrix-org/matrix-rust-sdk
•
Updated Apr 3, 2023
Description
Published by the National Vulnerability Database
Sep 29, 2022
Published to the GitHub Advisory Database
Sep 30, 2022
Reviewed
Sep 30, 2022
Last updated
Apr 3, 2023
Impact
When matrix-rust-sdk before 0.6 requests a room key from our devices, it correctly accepts key forwards only if they are a response to a previous request. However, it doesn't check that the device that responded matches the device the key was requested from.
This allows a malicious homeserver to insert room keys of questionable validity into the key store in some situations, potentially assisting in an impersonation attack. Note that even if key injection succeeds in this way, all forwarded keys have the
imported
flag set, which is used as an indicator that such keys have lesser authentication properties (and should be marked as such in clients, e.g. with a grey shield besides the message).For more information
If you have any questions or comments about this advisory, e-mail us at [email protected].
References