Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to download whole series from series view #1272

Merged
merged 4 commits into from
Oct 31, 2024

Conversation

ISO-B
Copy link
Contributor

@ISO-B ISO-B commented Jul 27, 2024

Why/Use case:
When traveling my kid has phone for listening audiobooks, but doesn't have access to internet so I needed to download books for him. We have quite lot of children books that are sort, but there might be tens of books in single series. This will make downloading those series much faster.

What is done:
Added new menu item to toolbar for downloading whole Serie with single click. This should only be visible in serie view. It will only download books(audio and ebook) that are missing from devices. Tested with android device, but I don't have access to IOS device so couldn't test with that.

I have very limited experience with Vue so there might be some dumb mistakes.

Copy link
Contributor

@nichwall nichwall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working for me on Android 14 on a Pixel 6a. Looks good to me overall. :)

My main comments are:

pages/bookshelf/series/_id.vue Outdated Show resolved Hide resolved
pages/bookshelf/series/_id.vue Outdated Show resolved Hide resolved
- Move download button from menu to toolbar
- Changed download confirmation message
- Changed serie to series
@ISO-B
Copy link
Contributor Author

ISO-B commented Sep 7, 2024

  • Download file count problem should be now fixed as I changed confirmation message to suggested. It makes more sense now
  • Moved download button to toolbar
  • Changed Serie -> Series. For non native English speaker that word is strange as singular and plural are same and word ends with s. Noticed that thing while writing code for android auto part of app, but forget to correct it in this part.

@nichwall
Copy link
Contributor

nichwall commented Sep 7, 2024

Thanks! Yeah, English is weird.

I just tested, and noticed if you press "download", "cancel", "download", the size and file count are not reset. The download is still correct, it is only the dialog box which is wrong. That did let me see that "MB" and "GB" were displayed correctly. :)

Another thought, do we want to hide the download button if all books are already downloaded? Or maybe we don't need to hide it and just have the popup say "Series is already downloaded".

- File and size resets every time when download is triggered
- If everything is downloaded show popup to tell it to user
@ISO-B
Copy link
Contributor Author

ISO-B commented Sep 7, 2024

Good catch. Now that you mentioned it it makes sense. Previously I thought that is was because there was cover for each book and count was double. It is now fixed.

I added popup to tell that everything is downloaded if user tries to download when everything is already downloaded.

@ISO-B ISO-B changed the title Added ability to download whole serie from serie view Added ability to download whole series from series view Sep 13, 2024
@ISO-B ISO-B requested a review from nichwall October 27, 2024 20:08
Copy link
Contributor

@nichwall nichwall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me on Android. Think we can merge this before the next app release @advplyr ?

@advplyr
Copy link
Owner

advplyr commented Oct 31, 2024

This is great, tested on android and ios. Thanks!

@advplyr advplyr merged commit f7663fc into advplyr:master Oct 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants