-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ability to download whole series from series view #1272
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working for me on Android 14 on a Pixel 6a. Looks good to me overall. :)
My main comments are:
- While "serie" is technically a word in English, it is pretty much never used in favor of "series". Led me to an interesting read, though! https://english.stackexchange.com/questions/483198/when-did-serie-become-obsolete-in-english
- The download file count is incorrect for ebooks.
- The download button would probably be better in the bar instead of in the dropdown until there are more items to put in the dropdown.
- Move download button from menu to toolbar - Changed download confirmation message - Changed serie to series
|
Thanks! Yeah, English is weird. I just tested, and noticed if you press "download", "cancel", "download", the size and file count are not reset. The download is still correct, it is only the dialog box which is wrong. That did let me see that "MB" and "GB" were displayed correctly. :) Another thought, do we want to hide the download button if all books are already downloaded? Or maybe we don't need to hide it and just have the popup say "Series is already downloaded". |
- File and size resets every time when download is triggered - If everything is downloaded show popup to tell it to user
Good catch. Now that you mentioned it it makes sense. Previously I thought that is was because there was cover for each book and count was double. It is now fixed. I added popup to tell that everything is downloaded if user tries to download when everything is already downloaded. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me on Android. Think we can merge this before the next app release @advplyr ?
This is great, tested on android and ios. Thanks! |
Why/Use case:
When traveling my kid has phone for listening audiobooks, but doesn't have access to internet so I needed to download books for him. We have quite lot of children books that are sort, but there might be tens of books in single series. This will make downloading those series much faster.
What is done:
Added new menu item to toolbar for downloading whole Serie with single click. This should only be visible in serie view. It will only download books(audio and ebook) that are missing from devices. Tested with android device, but I don't have access to IOS device so couldn't test with that.
I have very limited experience with Vue so there might be some dumb mistakes.