Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow connection attempt to local server when internet is not available #1314

Closed
wants to merge 1 commit into from

Conversation

ashanrath
Copy link

Removed the !networkConnected condition on the disabled state for the address input field and the submit button. Text is unchanged, however allows a user to attempt to connect to a local resource even if they do not have an active internet connection.

Fixes #566

Removed the !networkConnected condition on the disabled state for the address input field and the submit button.
@ashanrath ashanrath marked this pull request as ready for review September 7, 2024 02:36
@ashanrath ashanrath changed the title Update ServerConnectForm.vue Allow connection attempt to local server when internet is not available Sep 7, 2024
@advplyr
Copy link
Owner

advplyr commented Oct 31, 2024

Have you tested everything else like downloading, streaming, etc?

@ashanrath
Copy link
Author

Have you tested everything else like downloading, streaming, etc?

Tested streaming and downloading, both work with no issues. Modified APK with these changes incorporated, deployed to Pixel 7a, tested on both Android 14 and 15. Once you're connected to the server everything seems to work as normal. Also tested connections via direct IP address and FQDN, which had been hardcoded to the dnsmasq service on my router for exactly this scenario.

@advplyr
Copy link
Owner

advplyr commented Nov 2, 2024

What I'm confused about is there are a few places that use networkConnected other than the server connection form.

The library dropdown in the appbar wouldn't show if that was false. The home page shelves wouldn't load if it was false, only downloaded items would show on the home page.

@advplyr
Copy link
Owner

advplyr commented Nov 3, 2024

I think this got fixed in fe9168c.

And for iOS 358197d

Since this was only a partial fix for the server connect page I will close this out but if those commits didn't fix the issue we can revisit

@advplyr advplyr closed this Nov 3, 2024
@ashanrath ashanrath deleted the disable_offline_check branch November 4, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to play off local server without internet connection
3 participants