Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Number of books in library should be comma-delimited (depending on region settings) if number exceeds 1,000 #3370

Closed
ZLoth opened this issue Sep 2, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@ZLoth
Copy link

ZLoth commented Sep 2, 2024

Type of Enhancement

Web Interface/Frontend

Describe the Feature/Enhancement

If number of books exceeds one thousand, then the number should be comma delimited (depends on region settings). This follows previous feature requests for the same thing in stats.

Why would this be helpful?

Readability.

Future Implementation (Screenshot)

image

Audiobookshelf Server Version

2.13.2

Current Implementation (Screenshot)

image

@ZLoth ZLoth added the enhancement New feature or request label Sep 2, 2024
@advplyr advplyr added the awaiting release Issue is resolved and will be in the next release label Sep 6, 2024
@advorsky73
Copy link

it should be according to region. EU would prefer 1.300 instead of 1,300.
Thanks!

@ZLoth
Copy link
Author

ZLoth commented Sep 9, 2024

it should be according to region. EU would prefer 1.300 instead of 1,300. Thanks!

The folks who maintain the ABS code has been extremely good on applying regional settings.

Copy link

github-actions bot commented Sep 9, 2024

Fixed in v2.13.4.

@github-actions github-actions bot closed this as completed Sep 9, 2024
@github-actions github-actions bot removed the awaiting release Issue is resolved and will be in the next release label Sep 9, 2024
nichwall pushed a commit to nichwall/audiobookshelf that referenced this issue Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants