Add highlight annotations to ebooks #2601
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, quick question, I found this PR a while ago and was looking forward for it to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the ability to highlight and save text in epubs. Saved bookmarks reuse the existing "search book" ui.
To accomplish this, I used the existing bookmark schema, with the
timeproperty storing the CFI of the highlighted text.This posed a dilemma if a library item has both an audiobook and an ebook because they share the same id, so I extended the bookmark schema and api with a
typeproperty, which defaults toaudio. This could cause problems if the ebook file changes after bookmarks are added, but that could probably be solved with some type of fingerprinting.resolves #1558
resolves #1709
Should be compatible with #2584, but if not, I'll resolve any conflicts.