Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #2324.
This adds a migration to convert the
mediaId
column in thelibraryItems
table to be a UUID instead of a UUIDv4. After performing the migration on my test server, everything still seemed to be linked correctly betweenmediaProgress
,libraryItem
,books
, andpodcasts
, where deleting a book did cascade correctly. I was also able to scan my library and saw new rows created correctly in each table.The only performance difference I saw was in the noise (less than 3 ms difference on any given query).
I am a little hesitant about this change if anything goes wrong during the migration due to SQLite copying the table, creating a new table, then moving data over. From my reading, this can trigger delete cascades, but I did not experience that in my testing. Additional reading at https://sequelize.org/docs/v6/other-topics/query-interface/#changing-and-removing-columns-in-sqlite and https://stackoverflow.com/a/70486686