Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Typescript Compiler Issue #58

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Fixed Typescript Compiler Issue #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/publish-decision-spec-packages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,15 +44,15 @@ jobs:
- id: db6068b8-f5ed-4968-847e-b642595243fd
name: Install Typescript Compiler Globally
run: |
npm install --global [email protected]
npm install --global typescript@5.2.x
tsc --version

- id: e842d27d-141c-47f2-b64c-2c5702984edf
name: Compile Package
working-directory: ${{ env.WORKINGDIRECTORY_DECISION }}
run: |
tsc --outDir dist --declaration --target es5 --moduleResolution nodenext --lib es6,dom --showConfig *.ts
tsc --outDir dist --declaration --target es5 --moduleResolution nodenext --lib es6,dom *.ts
tsc --outDir dist --declaration --target es5 --module nodenext --moduleResolution nodenext --lib es6,dom --showConfig *.ts
tsc --outDir dist --declaration --target es5 --module nodenext --moduleResolution nodenext --lib es6,dom *.ts

- id: edd89b5d-54fa-4951-8206-54b1cef91968
name: Configure Project-Level .npmrc File
Expand Down
35 changes: 27 additions & 8 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,24 +7,43 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

## [1.0.12] - 2023-08-29

### Fixed

- [sc-49448] Updated Typescript compiler options to fix [breaking change](https://devblogs.microsoft.com/typescript/announcing-typescript-5-2-rc/#module-and-moduleresolution-must-match-under-recent-node-js-settings) between `v5.1.x` to `v5.2.x`. By [@honeycomb-cheesecake](https://github.com/honeycomb-cheesecake).
- [sc-49448] Removed unnecessary instances of `[sc-48140]` from `CHANGELOG.md`. By [@honeycomb-cheesecake](https://github.com/honeycomb-cheesecake).

### Changed

- [sc-49448] Fixed Typescript compiler version to `v5.2.x`. By [@honeycomb-cheesecake](https://github.com/honeycomb-cheesecake).

## [1.0.11] - 2023-08-29

### Added

- [sc-33985] Added an `includeArchived` option to the List Creative Templates endpoint for listing archived creative templates. By [@ryuichis](https://github.com/ryuichis).

## [1.0.10] - 2023-08-15

### Fixed

- [sc-48140] Targeting Javascript `ES5` instead of `ES6` for compatability. By [@honeycomb-cheesecake](https://github.com/honeycomb-cheesecake).
- [sc-48140] Fixed clean script. By [@honeycomb-cheesecake](https://github.com/honeycomb-cheesecake).

## [1.0.9] - [sc-48140] 2023-08-15
## [1.0.9] - 2023-08-15

### Nothing

- Problem with deploy due to GITHUB_REF_NAME, so republished. By [@honeycomb-cheesecake](https://github.com/honeycomb-cheesecake).

## [1.0.8] - [sc-48140] 2023-08-15
## [1.0.8] - 2023-08-15

### Fixed

- [sc-48140] Added `npm publish` option `--access=public` to permit publish to public npm registry and not receive `You must sign up for private packages` due to scoped packages [being `restricted` by default](https://docs.npmjs.com/cli/v8/commands/npm-publish#access). By [@honeycomb-cheesecake](https://github.com/honeycomb-cheesecake).

## [1.0.7] - [sc-48140] 2023-08-15
## [1.0.7] - 2023-08-15

### Fixed

Expand All @@ -41,25 +60,25 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- [sc-48140] Entries to `.gitignore` to assist testing of workflows. By [@honeycomb-cheesecake](https://github.com/honeycomb-cheesecake).
- [sc-48140] Added work card ids to changelog for tracking. By [@honeycomb-cheesecake](https://github.com/honeycomb-cheesecake).

## [1.0.6] - [sc-48140] 2023-08-14
## [1.0.6] - 2023-08-14

### Added

- [sc-48140] Debug statement to workflow. By [@honeycomb-cheesecake](https://github.com/honeycomb-cheesecake).

## [1.0.5] - [sc-48140] 2023-08-14
## [1.0.5] - 2023-08-14

### Fixed

- [sc-48140] Typescript compiler error by fixing to version `5.x` on install. By [@honeycomb-cheesecake](https://github.com/honeycomb-cheesecake).

## [1.0.4] - [sc-48140] 2023-08-14
## [1.0.4] - 2023-08-14

### Fixed

- [sc-48140] GitHub Actions working directory references `publish-decision-spec-packages.yml`. By [@honeycomb-cheesecake](https://github.com/honeycomb-cheesecake).

## [1.0.3] - [sc-48140] 2023-08-14
## [1.0.3] - 2023-08-14

### Fixed

Expand All @@ -69,7 +88,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

- [sc-48140] `package.json` file version to latest released. By [@honeycomb-cheesecake](https://github.com/honeycomb-cheesecake).

[1.0.2] - [sc-48140] 2023-08-14
## [1.0.2] - 2023-08-14

### Changed

Expand Down