Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PHP 8.2] Replace Math::randomInt() internals, use Random\Randomizer #150

Closed
aedart opened this issue Feb 19, 2023 · 0 comments
Closed

[PHP 8.2] Replace Math::randomInt() internals, use Random\Randomizer #150

aedart opened this issue Feb 19, 2023 · 0 comments
Assignees
@aedart
Labels
enhancement New feature or request
Milestone
v8.x

Comments

@aedart
Copy link
Owner

aedart commented Feb 19, 2023

Description

From PHP v8.2, the Random\Randomizer is made available. The utils Math::randomInt() should be refactored or redesigned to use this instead, with an option to specify the desired engine... Or alternatively, perhaps remove this entirely? (Not sure that a wrapper method is required anymore)!
@aedart aedart added the enhancement New feature or request label Feb 19, 2023
@aedart aedart added this to the v8.x milestone Feb 19, 2023
@aedart aedart mentioned this issue Feb 19, 2023
Closed
aedart added a commit that referenced this issue Mar 14, 2024
@aedart
Change description of randomInt()
0a50d1c 
#150
aedart added a commit that referenced this issue Mar 14, 2024
@aedart
Add factory for Randomizer
b2a35e7 
Factory doesn't do anything special - added for the sake of convenience.

#150
aedart added a commit that referenced this issue Mar 14, 2024
@aedart
Add Randomizer interface
defbaa2 
#150
aedart added a commit that referenced this issue Mar 14, 2024
@aedart
Change factory to return new Randomizer (adapter)
6826e05 
#150
aedart added a commit that referenced this issue Mar 14, 2024
@aedart
Fix missing @throw for nextInt()
8d2f61d 
#150
aedart added a commit that referenced this issue Mar 14, 2024
@aedart
Fix missing @throws for shuffleBytes()
9fe1ed0 
#150
aedart added a commit that referenced this issue Mar 14, 2024
@aedart
Add unit tests for Randomizer
c5c37be 
#150
aedart added a commit that referenced this issue Mar 14, 2024
@aedart
Split Randomizer into smaller interfaces
642d0cf 
#150
aedart added a commit that referenced this issue Mar 14, 2024
@aedart
Fix style
c74e453 
#150
aedart added a commit that referenced this issue Mar 14, 2024
@aedart
Add randmized()
731dff5 
#150
aedart added a commit that referenced this issue Mar 14, 2024
@aedart
Add randomized()
27864de 
#151, #150
aedart added a commit that referenced this issue Mar 14, 2024
@aedart
Add randomized()
5c8b71b 
#150, #151
aedart added a commit that referenced this issue Mar 14, 2024
@aedart
Rename randomized() to randomizer()
130d908 
Name makes more sense now.

#150, #151
aedart added a commit that referenced this issue Mar 14, 2024
@aedart
Deprecate randomInt()
425cb5a 
Replaced by int() in NumericRandomizer.

#150
aedart added a commit that referenced this issue Mar 15, 2024
@aedart
Redesign Randomizer, extract into small self-contained "drivers"
ccaf926 
Now each type of randomizer has its own responsibilities and less changes of naming conflicts (e.g. shuffleBytes() vs. shuffleArray() have both been renamed to shuffle()).

#150, #151
@aedart aedart mentioned this issue Mar 15, 2024
Merged
@aedart aedart self-assigned this Mar 15, 2024
@aedart aedart closed this as completed Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aedart aedart

Labels
enhancement New feature or request
Projects
None yet
Milestone
v8.x
Development

No branches or pull requests
1 participant
@aedart