-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove valuerrors #508
base: main
Are you sure you want to change the base?
Remove valuerrors #508
Conversation
to get the full traceback
…ctual exception after rollback. Return the value in an else block
but let FastAPI log them and return an error 500
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
7298664 | Triggered | Generic Password | d1d6708 | tests/test_auth.py | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## ruff-new-rules #508 +/- ##
==================================================
+ Coverage 83.12% 83.24% +0.12%
==================================================
Files 98 98
Lines 6197 6182 -15
==================================================
- Hits 5151 5146 -5
+ Misses 1046 1036 -10 ☔ View full report in Codecov by Sentry. |
3cac6a4
to
dbaeb1e
Compare
Description
Please explain the changes you made here.
Checklist