Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove valuerrors #508

Draft
wants to merge 23 commits into
base: main
Choose a base branch
from
Draft

Remove valuerrors #508

wants to merge 23 commits into from

Conversation

armanddidierjean
Copy link
Member

Description

Please explain the changes you made here.

Checklist

  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the documentation, if necessary

Copy link

gitguardian bot commented Aug 6, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
7298664 Triggered Generic Password d1d6708 tests/test_auth.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@armanddidierjean armanddidierjean changed the base branch from main to ruff-new-rules August 6, 2024 06:33
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 36.66667% with 19 lines in your changes missing coverage. Please review.

Project coverage is 83.24%. Comparing base (78fcfa3) to head (c286970).

Files Patch % Lines
app/modules/booking/cruds_booking.py 0.00% 8 Missing ⚠️
app/modules/advert/cruds_advert.py 0.00% 6 Missing ⚠️
app/modules/amap/cruds_amap.py 0.00% 2 Missing ⚠️
app/modules/calendar/cruds_calendar.py 0.00% 2 Missing ⚠️
app/utils/initialization.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           ruff-new-rules     #508      +/-   ##
==================================================
+ Coverage           83.12%   83.24%   +0.12%     
==================================================
  Files                  98       98              
  Lines                6197     6182      -15     
==================================================
- Hits                 5151     5146       -5     
+ Misses               1046     1036      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@armanddidierjean armanddidierjean force-pushed the ruff-new-rules branch 2 times, most recently from 3cac6a4 to dbaeb1e Compare August 7, 2024 09:49
Base automatically changed from ruff-new-rules to main August 7, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant