Replace all host and Repository.displayHost with Repository.host

[Marc-Andrieu]

Fix #444
However, the decode argument in getOne seems useless: now it's an unused argument, and its only appearance was here

Titan/lib/tools/repository/repository.dart

Line 116 in 318f0b3

if (host == displayHost || decode) {

which evaluates to true || decode which is true no matter the value of decode

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 10.00000% with 18 lines in your changes missing coverage. Please review.

Project coverage is 53.88%. Comparing base (318f0b3) to head (94285f4).

Files with missing lines	Patch %	Lines
lib/tools/repository/repository.dart	11.11%	8 Missing ⚠️
lib/tools/repository/logo_repository.dart	0.00%	7 Missing ⚠️
lib/admin/repositories/group_repository.dart	0.00%	1 Missing ⚠️
lib/auth/providers/openid_provider.dart	0.00%	1 Missing ⚠️
lib/auth/repository/openid_repository.dart	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #445      +/-   ##
==========================================
+ Coverage   53.82%   53.88%   +0.05%     
==========================================
  Files         168      168              
  Lines        3727     3723       -4     
==========================================
  Hits         2006     2006              
+ Misses       1721     1717       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Marc-Andrieu]

Making host a static string makes it impossible to override, so Centralisation is broken.

I hesitate between three solutions regarding the short file https://github.com/aeecleclair/Titan/blob/main/lib/centralisation/repositories/section_repository.dart:

• Not extending it from Repository in the first place: the Repository class is too complex (tokens, host, endpoints, etc), because it's made to handle the responses of a complete API. Here we just want to get a JSON file.
• Still extending it from Repository, but using native http.get instead of getOne. But some exception handling should be written for Centralisation. Also, not using getOne in this short file makes it useless to extend from Repository
• Asking Hyperion to get it for us. The only negative part is that it may be a bit slower for the UX. But we would keep using getOne, and https://centralisation.eclair.ec-lyon.fr would not be hard-coded anymore (well actually it's also in the constant imagePath)

[Marc-Andrieu]

BTW, notice the rare cases of requests not to Hyperion (namely for the fonts, Centralisation's SVG files, for Plausible, etc) do not use methods of Repository so the 1st solution seems OK (and there are few possible errors when not receiving the JSON).

[maximeroucher]

The last option is best in terms of practices, however, it will require a lot f work for only one endpoint, which is a bit overkill.
Consider going for it if multiple services a being handled this way (we already change the cinéma module for instance)