Add default sort label (comment vs post) to action sheet (#1471)

Resolves #1456
aeharding · May 11, 2024 · ca4e79c · ca4e79c
1 parent beed451
commit ca4e79c
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 5 deletions.
diff --git a/src/features/feed/PostSort.tsx b/src/features/feed/PostSort.tsx
@@ -121,13 +121,20 @@ export default function PostSort({ sort, setSort }: PostSortProps) {
   );
 }
 
-export function useSelectPostSort(onSelected: (sort: SortType) => void) {
+interface Options {
+  title?: string;
+}
+
+export function useSelectPostSort(
+  onSelected: (sort: SortType) => void,
+  options?: Options,
+) {
   const [presentInitialSortActionSheet] = useIonActionSheet();
   const [presentTopSortActionSheet] = useIonActionSheet();
 
   function present(sort: SortType) {
     presentInitialSortActionSheet({
-      header: "Sort by...",
+      header: options?.title ?? "Sort by...",
       cssClass: "left-align-buttons",
       buttons: BUTTONS.map((b) => ({
         ...b,

diff --git a/src/features/settings/general/comments/DefaultSort.tsx b/src/features/settings/general/comments/DefaultSort.tsx
@@ -13,6 +13,7 @@ export default function DefaultSort() {
   return (
     <SettingSelector
       title="Default Sort"
+      openTitle="Default Comment Sort"
       selected={defaultCommentSort}
       setSelected={setDefaultCommentSort}
       options={OCommentDefaultSort}

diff --git a/src/features/settings/general/posts/DefaultSort.tsx b/src/features/settings/general/posts/DefaultSort.tsx
@@ -15,9 +15,12 @@ export default function DefaultSort() {
     (state) => state.settings.general.posts.sort,
   );
 
-  const present = useSelectPostSort((newSort) => {
-    dispatch(setDefaultPostSort(newSort));
-  });
+  const present = useSelectPostSort(
+    (newSort) => {
+      dispatch(setDefaultPostSort(newSort));
+    },
+    { title: "Default Post Sort" },
+  );
 
   return (
     <IonItem button onClick={() => present(defaultPostSort)} detail={false}>