Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use distroless docker base image for dnsmasq-controller #7

Merged
merged 1 commit into from
May 31, 2024

Conversation

be185057
Copy link
Contributor

Google provides lightweight distroless images to build containers from, see more info here: https://github.com/GoogleContainerTools/distroless
This is more lightweight than alpine and comes with a number of other benefits.

This PR updates the Dockerfile used to build the dnsmasq-controller Dockerfile to use one of these distroless images.

@be185057
Copy link
Contributor Author

Had to employ some fiddly back-and-forth with the passwd and group files in /etc as dnsmasq requires a user&group to run but these aren't present on the distroless image & also can't be created normally because the distroless image has no shell. (also has no package manager so dnsmasq can't be installed directly onto the distroless image - it get's installed onto an ephemeral alpine container and then copied, along with some dependency libraries, to the distroless image)

@bc185174
Copy link
Contributor

#6

Copy link
Member

@kvaps kvaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, I'm very sorry for sych long reply, LGTM

@kvaps kvaps merged commit 5a0085c into aenix-io:master May 31, 2024
@kvaps kvaps mentioned this pull request May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants