Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add path to endpoint.ex in installation guide for Phoenix 1.7 #293

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

azyzz228
Copy link

Added clarification for newbies (like me) on where (endpoint) to enable Router Helpers so that kaffy works in Phoenix 1.7

Added clarification for newbies (like me) on where (endpoint) to enable Router Helpers so that kaffy works in Phoenix 1.7
@lewazo
Copy link

lewazo commented Sep 18, 2023

This is usually not in endpoint.ex, but in lib/your_app_web.ex.

@@ -145,6 +145,7 @@ Follow the instructions at https://hexdocs.pm/phoenix_view/Phoenix.View.html

You will also need to change `helpers: false` to `true` as shown in example below.
```elixir
# in your lib/you_app_web/endpoint.ex
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition! Don't know how the filename wasn't mentioned here!
Just to be consistent with the rest of the docs, since we're using "my app" instead of "your app", could you please make this lib/my_app_web.ex and it'll be ready to merge.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oooh my bad =D

@ghenry
Copy link
Collaborator

ghenry commented Apr 25, 2024

Can we fix this up again and I'll merge. Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants