Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for Kaffy.ResourceQuery #310

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

brandonjoyce
Copy link

@brandonjoyce brandonjoyce commented May 3, 2024

I made some assumption in this PR that I don't know if you'll like or not such as adding Docker and ExMachina. Let me know if I'm way off and there's a better way.

  • Added docker-compose.yml w/ postgres for testing queries against a database
  • Adding migration, repo, factories, and aliases for test schema
  • Adding test coverage for Kaffy.ResourceQuery Add Tests #7
  • Changing CI script to handle postgres setup

This is in preparation for changes I need to make that relate to #278

@brandonjoyce brandonjoyce force-pushed the add-tests-for-resource-query branch from 4326f24 to 88834e2 Compare May 7, 2024 21:22
@brandonjoyce brandonjoyce marked this pull request as ready for review May 7, 2024 21:25
@aesmail
Copy link
Owner

aesmail commented May 29, 2024

@brandonjoyce thank you for this PR. I think it's needed. I will check it out and merge it for next week's v0.11.0 release if all is good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants