feat(package): build es version compatible with node #1371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1371 +/- ##
===========================================
+ Coverage 88.18% 88.26% +0.07%
===========================================
Files 56 56
Lines 3098 3101 +3
Branches 39 39
===========================================
+ Hits 2732 2737 +5
+ Misses 345 343 -2
Partials 21 21
Continue to review full report at Codecov.
|
subhod-i
approved these changes
Jan 21, 2022
thepiwo
reviewed
Jan 22, 2022
.github/workflows/main.yml
Outdated
| fetch-depth: 100 | ||
| - if: github.ref != 'refs/heads/develop' | ||
| run: git branch develop origin/develop | ||
| fetch-depth: 50 |
There was a problem hiding this comment.
why do we need fetch-depth at all?
There was a problem hiding this comment.
ah I see, to lint the last 50 commits
src/chain/index.js
Outdated
| deepProps: { Ae: { defaults: { waitMined: true, verify: true } } } | ||
| deepProps: { | ||
| Ae: { | ||
| defaults: { |
src/chain/index.js
Outdated
| } | ||
| }, | ||
| methods: { | ||
| _getPollInterval (type) { |
There was a problem hiding this comment.
so, these all are changes from #1369, I've rebased this PR on the top of develop and they are not visible in the diff anymore
thepiwo
approved these changes
Jan 22, 2022
davidyuk
force-pushed
the
feature/es-node-compat
branch
from
21d475a
to
480c747
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #1369 (needed for cli)
So, after this would be possible to do:
and execute it using plain node: