Fix CI in bevy-0.13 branch #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Authored-by: RobWalt <[email protected]>
Authored-by: RobWalt <[email protected]>
Ok to be fair this doesn't change a lot. It saves one indirection through the `TryFrom` trait which might even gets optimized away in the first place. Nevertheless it is a bit more explicit which will help newer people to understand the code and develop good habits. Authored-by: RobWalt <[email protected]>
aevyrie
approved these changes
Feb 23, 2024
|
Thanks! |
aevyrie
added a commit
that referenced
this pull request
Feb 23, 2024
* update to bevy 0.13 * clippy * touch up examples * free perf lying around in a hot loop * Bump version * add no culling to benches * add perf notes to changelog * Fix CI in bevy-0.13 branch (#111) * fix(tests): QueryFilter fixed to be in filter position Authored-by: RobWalt <[email protected]> * chore(cleanup): remove unneeded `Mesh::from` Authored-by: RobWalt <[email protected]> * chore(cleanup): use Direction3D API directly Ok to be fair this doesn't change a lot. It saves one indirection through the `TryFrom` trait which might even gets optimized away in the first place. Nevertheless it is a bit more explicit which will help newer people to understand the code and develop good habits. Authored-by: RobWalt <[email protected]> --------- Co-authored-by: Robert Walter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the doc test in the bevy-0.13 branch to make CI green again.