Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove angle as a component #5

Merged
merged 1 commit into from
Jan 23, 2022
Merged

Remove angle as a component #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions rfcs/12-primitive-shapes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,13 +105,6 @@ The complete overview of shapes, their dimensions and their names can be seen in

## Implementation strategy

### Helper Types

```rust
/// Stores an angle in radians, and supplies builder functions to prevent errors (from_radians, from_degrees)
struct Angle(f32);
```

### Traits (REFERENCE ONLY!)

**These traits are provided as reference to illustrate how these primitive shape types might be used. The details of implementation and interface should be determined in a separate RFC, PR, or independent prototypes.**
Expand Down Expand Up @@ -194,7 +187,7 @@ struct RegularPolygon2d {
/// Number of faces.
faces: u8,
/// Clockwise rotation of the polygon about the origin. At zero rotation, a point will always be located at the 12 o'clock position.
orientation: Angle,
orientation: f32,
}
impl Meshable for RegularPolygon2d {}

Expand Down