ui: truncate paths in hdr box #956
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afnanenayet
force-pushed
the
afnan/truncate-paths-in-hdr
branch
3 times, most recently
from
8998967
to
77c9fc0
Compare
Adds a module for string utils and a small utility function to truncate strings.
Adds a macro to more efficiently concatenate strings, since I noticed
there is some code I have to concatenate strings that use
`format!("{}{}...{})`, which might not be particularly efficient.
This macro is also much more ergonomic to use.
When rendering a diff in the "unified" style, a long path name will be truncated to fit the terminal width in the box at the top where we display the filenames being diffed.
afnanenayet
force-pushed
the
afnan/truncate-paths-in-hdr
branch
from
77c9fc0
to
b744abd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add string utilities and apply string truncation to the top of the header box where we show the filenames being diffed.
If you have a diff between two files with very long paths where a path might exceed the length of the terminal, diffsitter used to display something like this:
And if your terminal was too short, the text would wrap around.
Now it will look something like this: