Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Move the plugins.php GitHub icon to the auto-updates column #1049

Conversation

BrianHenryIE
Copy link
Contributor

Change:

Screenshot 2023-09-10 at 3 44 27 PM

to:

Screenshot 2023-09-10 at 3 50 36 PM

The icon is currently added to the plugin_row_meta list. This instead appends it to the plugin_auto_update_setting_html (there is no filter for the array of items).

Personally, I consider the first column (actions) to be links internal to the site, the second (meta) to be external links, and since the relatively new third column's topic is automatic updates, it seems appropriate for an icon representing an updates function.

@afragen
Copy link
Owner

afragen commented Sep 10, 2023

I like it where it is.

@afragen
Copy link
Owner

afragen commented Sep 10, 2023

It's not so much that the icon represents where the update comes from. It represents where the repo is hosted.

There are icons for Bitbucket, GitLab, and Gitea.

@BrianHenryIE
Copy link
Contributor Author

I add links to GitHub on my plugins, like:

Screenshot 2023-09-10 at 4 22 24 PM

So in this case, the icon Git Updater adds (not present in screenshot which was quickly grabbed from a local wp-env) is representative of where the update is coming from, slightly distinct from "where the repo is hosted". While it is a nice touch to communicate where the repo is hosted, the business of the plugin is updating, hence I think the Automatic Updates column is most appropriate.

But your preference is fine. I figured it was a small enough suggested change that I should open a PR rather than an issue when bringing it up.

I'd prefer if that column were called just Updates, not Automatic Updates. I've been meaning to add update install date tracking to the Plugins Page plugin I mentioned yesterday and I'll add its UI in that column.

Thanks for Git Updater, it's a nice piece of work. I also just installed oEmbed Gists and Files yesterday and am subscribed to the wp-dependency-installer Trac ticket. Appreciate your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants