Update WebVRPolyfill to 0.10.3 to fix Chrome devicemotion regression #3453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsantell
commented
Mar 15, 2018
| window.WebVRConfig = window.WebVRConfig || { | ||
| // WebVR polyfill | ||
| var WebVRPolyfill = require('webvr-polyfill'); | ||
| window.webvrpolyfill = new WebVRPolyfill({ |
There was a problem hiding this comment.
Can remove, might be helpful for debugging in the future
jsantell
force-pushed
the
polyfill-0.10.3
branch
from
b62e177
to
1002e1e
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This also handles Chrome changes in devicemotion in m65-m67. More information can be found in the 0.10.3 release notes of the issues, but as of now, this is necessary for A-Frame to work in current versions of Chrome.
I'd suggest checking out the 0.10.0 the release notes as well to confirm there hasn't been any feature changes that is necessary for A-Frame.
I believe this would fix #3427
Changes proposed:
Tested
Pixel
iPhone 10.3.3
iPhone X iOS 11.2.6