Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form Daily2- Temperature #57

Open
shadrackkibet opened this issue May 22, 2018 · 4 comments
Open

Form Daily2- Temperature #57

shadrackkibet opened this issue May 22, 2018 · 4 comments
Labels
Lesotho Feedback Feedback from testing CLIMSOFT in Lesotho Met workshop

Comments

@shadrackkibet
Copy link

Lesotho Met data entry team would like to have a check for Tmin and Tmax being done on the form. There is no instance whereby Tmax < Tmin and therefore they would like Climsoft not to allow that.

@maxwellfundi maxwellfundi added the Lesotho Feedback Feedback from testing CLIMSOFT in Lesotho Met workshop label May 22, 2018
Patowhiz pushed a commit that referenced this issue Jun 16, 2018
@Patowhiz
Copy link

@mhabimana and @smachua what's your opinion on this. This can be done but the assumption here will be that one of the two, either tmin or tmax must be entered before the other for such a comparison to be valid

@mhabimana
Copy link

@Patowhiz : The reason why there is no check for TMax and TMin on the form Daily2 is because,this form is meant to enter one element at time. If this was meant for many elements at a time,this could be obvious. In climsoft,this check is performed during the QC check (enter-element comparison check).

@Patowhiz
Copy link

@mhabimana I agree with you. We could leave this as it is. In addition, @shadrackkibet gave me logical reason as to why the lesotho teams preferred also to have the check on the form. And this can be trivially done on the data entry forms by just having them do the comparison during entry of these 2 elements only. Then we could just show a prompt(e.g Message box) about it and let the user to proceed with data entry, knowingly that he/she made an error.
I find it easier and quicker from the users perspective to check on errors in real time rather than in batch(which QC check does).

@mhabimana
Copy link

@Patowhiz : I suggest,you can try to implement this check and then we can test how it works.My view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Lesotho Feedback Feedback from testing CLIMSOFT in Lesotho Met workshop
Projects
None yet
Development

No branches or pull requests

4 participants