Skip to content

Commit

Permalink
Fix Unknown method: SetInteractive for `agama questions mode non-inte…
Browse files Browse the repository at this point in the history
…ractive` (#709)

We want to access Interactive, a writable property.

zbus-xmlgen generates a proxy for setting a writable property but
forgets to mark it as a property, generating a method call instead
  • Loading branch information
mvidner committed Aug 22, 2023
1 parent 55a84ba commit ccdc015
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
7 changes: 7 additions & 0 deletions rust/agama-dbus-server/src/network/nm/proxies.rs
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,7 @@ trait NetworkManager {
/// ConnectivityCheckEnabled property
#[dbus_proxy(property)]
fn connectivity_check_enabled(&self) -> zbus::Result<bool>;
#[dbus_proxy(property)]
fn set_connectivity_check_enabled(&self, value: bool) -> zbus::Result<()>;

/// ConnectivityCheckUri property
Expand All @@ -177,6 +178,7 @@ trait NetworkManager {
fn global_dns_configuration(
&self,
) -> zbus::Result<std::collections::HashMap<String, zbus::zvariant::OwnedValue>>;
#[dbus_proxy(property)]
fn set_global_dns_configuration(
&self,
value: std::collections::HashMap<&str, zbus::zvariant::Value<'_>>,
Expand Down Expand Up @@ -221,6 +223,7 @@ trait NetworkManager {
/// WimaxEnabled property
#[dbus_proxy(property)]
fn wimax_enabled(&self) -> zbus::Result<bool>;
#[dbus_proxy(property)]
fn set_wimax_enabled(&self, value: bool) -> zbus::Result<()>;

/// WimaxHardwareEnabled property
Expand All @@ -230,6 +233,7 @@ trait NetworkManager {
/// WirelessEnabled property
#[dbus_proxy(property)]
fn wireless_enabled(&self) -> zbus::Result<bool>;
#[dbus_proxy(property)]
fn set_wireless_enabled(&self, value: bool) -> zbus::Result<()>;

/// WirelessHardwareEnabled property
Expand All @@ -239,6 +243,7 @@ trait NetworkManager {
/// WwanEnabled property
#[dbus_proxy(property)]
fn wwan_enabled(&self) -> zbus::Result<bool>;
#[dbus_proxy(property)]
fn set_wwan_enabled(&self, value: bool) -> zbus::Result<()>;

/// WwanHardwareEnabled property
Expand Down Expand Up @@ -291,6 +296,7 @@ trait Device {
/// Autoconnect property
#[dbus_proxy(property)]
fn autoconnect(&self) -> zbus::Result<bool>;
#[dbus_proxy(property)]
fn set_autoconnect(&self, value: bool) -> zbus::Result<()>;

/// AvailableConnections property
Expand Down Expand Up @@ -374,6 +380,7 @@ trait Device {
/// Managed property
#[dbus_proxy(property)]
fn managed(&self) -> zbus::Result<bool>;
#[dbus_proxy(property)]
fn set_managed(&self, value: bool) -> zbus::Result<()>;

/// Metered property
Expand Down
1 change: 1 addition & 0 deletions rust/agama-lib/src/proxies.rs
Original file line number Diff line number Diff line change
Expand Up @@ -147,5 +147,6 @@ trait Questions1 {
/// Interactive property
#[dbus_proxy(property)]
fn interactive(&self) -> zbus::Result<bool>;
#[dbus_proxy(property)]
fn set_interactive(&self, value: bool) -> zbus::Result<()>;
}

0 comments on commit ccdc015

Please sign in to comment.