-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong UTC offset in the list of timezones #1335
Comments
The offset is calculated at the client side: https://github.com/openSUSE/agama/blob/f9c0c0d24390825cbe36cb54950a93113828d616/web/src/utils.js#L355. |
@jreidinger I cannot see the problem now. Can you guide me to find it? (BTW note how it shows the current UTC offset, applying the daylight savings time.) |
It happens only in some cases (I do not know how many). But some timezones are reported as UTC when they are not. Two examples: Atlantic/Canary (UTC+1) and Americas/Adak (UTC-9). |
Just in case it might help, would worth having a look at https://github.com/date-fns/tz Not only for using it if needed (I'd do if it make our code work as expected) but also to check if there is something to learn from its source code and tests, https://github.com/date-fns/tz/tree/main/src/tzOffset |
## Problem The UTC offset is not properly calculated, as shown in #1335. ## Solution * Reimplement the UTC calculation. * Rely on [@date-fns/tz](https://github.com/date-fns/tz). ## Screenshot ![Captura desde 2024-09-30 12-25-24](https://github.com/user-attachments/assets/389cf643-02f2-4509-8648-99f563348d75)
The problem is fixed in #1646. |
Reported by @jreidinger:
The text was updated successfully, but these errors were encountered: