Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

web: Allow opening popups with "stable" size #1156

Merged
merged 5 commits into from
Apr 19, 2024
Merged

web: Allow opening popups with "stable" size #1156

merged 5 commits into from
Apr 19, 2024

Commits on Apr 19, 2024

  1. web: Allow influence Popup size 

    By ignoring the PF/Modal's `variant` prop and adding `blockSize` and
`inlineSize` to core/Popup.

In addition to "auto", they support "small", "medium", and "large"
values that are converted into CSS classes to set the component size
based on the viewport.

The intention is to keep the dialog at a constant size regardless of its
content.

Developers should decide which size is best for a dialog based on its
content and behavior.
    @dgdavid
    dgdavid committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    f330d61 View commit details
    Browse the repository at this point in the history

  2. web: Adapt popups to use blockSize and inlineSize props 

    Only when needed.
    @dgdavid
    dgdavid committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    8163d5a View commit details
    Browse the repository at this point in the history

  3. web: CSS cleanup 

    CSS still needing much more love, but for now this commit just remove
some dead rules.
    @dgdavid
    dgdavid committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    5b37128 View commit details
    Browse the repository at this point in the history

  4. web: Fix core/Popup doc. 

    The default value for inlineSize porp is not "auto" but "medium".
    @dgdavid
    dgdavid committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    286592d View commit details
    Browse the repository at this point in the history

  5. web: Use blockSize="large" in SpacePolicyDialog 

    As proposed in code review.
    @dgdavid
    dgdavid committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    c307876 View commit details
    Browse the repository at this point in the history