Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): storage UI fixes and improvements #1351

Merged
merged 15 commits into from
Jun 19, 2024
Merged

Conversation

dgdavid
Copy link
Contributor

@dgdavid dgdavid commented Jun 17, 2024

Problem

No long ago a full UI rewrite was started and it was recently merged into master branch despite not being fully finished. It was just in a good shape for adhering to the release early, release often philosophy. The idea is to add fixes and improvements little by little against master branch according to the (internally) assigned priorities.

But the openSUSE conference is around the corner and there are few details we'd like to have more polished for the Agama in action and The future of Agama and openSUSE events.

Solution

Address some of these details as part of this PR. Go commit by commit to see them.

Testing

  • Tested manually
  • Adapted / re-enabled some unit tests.

Note for reviewers

No changelog entry required.

Screenshots

Click to show/hide
  • Transactional root file system alert

    Before After
    Screenshot from 2024-06-17 13-59-15 Screenshot from 2024-06-17 13-58-36
    Screenshot from 2024-06-17 13-59-19 Screenshot from 2024-06-17 13-58-46
  • TPM reminder look&feel

    Before After
    Screenshot from 2024-06-17 17-12-26 Screenshot from 2024-06-17 17-11-28
  • Accept button when manually selecting the boot device

    Before After
    Screenshot from 2024-06-17 22-14-04 Screenshot from 2024-06-17 22-13-02
  • Size unit selector

    Before After
    Screenshot from 2024-06-17 22-41-15 Screenshot from 2024-06-17 22-39-44

Related to https://trello.com/c/H3oZyzXS (internal link)

The storage alert for a transactional root file system was placed in the
header to keep it sticky there all the time. However, we've concluded
that should be enough to put it at the very top of the page with a
better, more prominent presentation. To so so, it stop using the custom
Agama/Reminder component in favor of PatternFly/Alert.
There were two problems:

- The code for getting the encryption data was commented out.
- The condition for displaying the hint was negated (for testing
  purposes)

This changes fix these problems and bring back the unit tests.
The Accept button does not get disabled when switching to the manual
mode. To do so, the code ensures the first device is selected when
proceed, keeping consistent with the option rendered in the UI.
@dgdavid dgdavid marked this pull request as ready for review June 17, 2024 22:06
@dgdavid dgdavid requested a review from ancorgs June 17, 2024 22:06
@dgdavid dgdavid changed the title WIP: ui fixes fix(web): storage UI fixes and improvements Jun 17, 2024
ancorgs

This comment was marked as resolved.

@dgdavid dgdavid requested a review from ancorgs June 18, 2024 09:51
Co-authored-by: José Iván López <[email protected]>
@coveralls
Copy link

Coverage Status

coverage: 70.875% (-0.002%) from 70.877%
when pulling b4819ac on pre-conference-fixes
into a5caf80 on master.

@coveralls
Copy link

Coverage Status

coverage: 70.881% (+0.004%) from 70.877%
when pulling 4af4b9c on pre-conference-fixes
into a5caf80 on master.

@coveralls
Copy link

Coverage Status

coverage: 70.879% (+0.002%) from 70.877%
when pulling e183ea8 on pre-conference-fixes
into a5caf80 on master.

@coveralls
Copy link

Coverage Status

coverage: 70.875% (-0.002%) from 70.877%
when pulling e183ea8 on pre-conference-fixes
into a5caf80 on master.

@joseivanlopez joseivanlopez merged commit c516de3 into master Jun 19, 2024
5 checks passed
@joseivanlopez joseivanlopez deleted the pre-conference-fixes branch June 19, 2024 10:39
@imobachgs imobachgs mentioned this pull request Jun 27, 2024
imobachgs added a commit that referenced this pull request Jun 27, 2024
Prepare for releasing Agama 9. It includes the following pull requests:

- #1101
- #1202
- #1228
- #1231
- #1236
- #1238
- #1239
- #1240
- #1242
- #1243
- #1244
- #1245
- #1246
- #1247
- #1248
- #1249
- #1250
- #1251
- #1252
- #1253
- #1254
- #1255
- #1256
- #1257
- #1258
- #1259
- #1260
- #1261
- #1264
- #1265
- #1267
- #1268
- #1269
- #1270
- #1271
- #1272
- #1273
- #1274
- #1279
- #1280
- #1284
- #1285
- #1286
- #1287
- #1288
- #1289
- #1290
- #1291
- #1292
- #1293
- #1294
- #1295
- #1296
- #1298
- #1299
- #1300
- #1301
- #1302
- #1303
- #1304
- #1305
- #1306
- #1307
- #1308
- #1309
- #1310
- #1311
- #1312
- #1313
- #1314
- #1315
- #1316
- #1317
- #1318
- #1319
- #1320
- #1321
- #1322
- #1323
- #1324
- #1325
- #1326
- #1328
- #1329
- #1331
- #1332
- #1334
- #1338
- #1340
- #1341
- #1342
- #1343
- #1344
- #1345
- #1348
- #1349
- #1351
- #1352
- #1353
- #1354
- #1355
- #1356
- #1357
- #1358
- #1359
- #1360
- #1361
- #1362
- #1363
- #1365
- #1366
- #1367
- #1368
- #1371
- #1372
- #1374
- #1375
- #1376
- #1379
- #1380
- #1381
- #1383
- #1384
- #1385
- #1386
- #1387
- #1388
- #1389
- #1391
- #1392
- #1394
- #1395
- #1397
- #1398
- #1399
- #1400
- #1403
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants