fix(web): storage UI fixes and improvements #1351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The storage alert for a transactional root file system was placed in the header to keep it sticky there all the time. However, we've concluded that should be enough to put it at the very top of the page with a better, more prominent presentation. To so so, it stop using the custom Agama/Reminder component in favor of PatternFly/Alert.
There were two problems: - The code for getting the encryption data was commented out. - The condition for displaying the hint was negated (for testing purposes) This changes fix these problems and bring back the unit tests.
The Accept button does not get disabled when switching to the manual mode. To do so, the code ensures the first device is selected when proceed, keeping consistent with the option rendered in the UI.
ancorgs
reviewed
Jun 18, 2024
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Co-authored-by: José Iván López <[email protected]>
dgdavid
force-pushed
the
pre-conference-fixes
branch
from
30b3427
to
01432f7
Compare
joseivanlopez
approved these changes
Jun 18, 2024
Co-authored-by: José Iván López <[email protected]>
Merged
imobachgs
added a commit
that referenced
this pull request
Jun 27, 2024
Prepare for releasing Agama 9. It includes the following pull requests: - #1101 - #1202 - #1228 - #1231 - #1236 - #1238 - #1239 - #1240 - #1242 - #1243 - #1244 - #1245 - #1246 - #1247 - #1248 - #1249 - #1250 - #1251 - #1252 - #1253 - #1254 - #1255 - #1256 - #1257 - #1258 - #1259 - #1260 - #1261 - #1264 - #1265 - #1267 - #1268 - #1269 - #1270 - #1271 - #1272 - #1273 - #1274 - #1279 - #1280 - #1284 - #1285 - #1286 - #1287 - #1288 - #1289 - #1290 - #1291 - #1292 - #1293 - #1294 - #1295 - #1296 - #1298 - #1299 - #1300 - #1301 - #1302 - #1303 - #1304 - #1305 - #1306 - #1307 - #1308 - #1309 - #1310 - #1311 - #1312 - #1313 - #1314 - #1315 - #1316 - #1317 - #1318 - #1319 - #1320 - #1321 - #1322 - #1323 - #1324 - #1325 - #1326 - #1328 - #1329 - #1331 - #1332 - #1334 - #1338 - #1340 - #1341 - #1342 - #1343 - #1344 - #1345 - #1348 - #1349 - #1351 - #1352 - #1353 - #1354 - #1355 - #1356 - #1357 - #1358 - #1359 - #1360 - #1361 - #1362 - #1363 - #1365 - #1366 - #1367 - #1368 - #1371 - #1372 - #1374 - #1375 - #1376 - #1379 - #1380 - #1381 - #1383 - #1384 - #1385 - #1386 - #1387 - #1388 - #1389 - #1391 - #1392 - #1394 - #1395 - #1397 - #1398 - #1399 - #1400 - #1403
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
No long ago a full UI rewrite was started and it was recently merged into
masterbranch despite not being fully finished. It was just in a good shape for adhering to the release early, release often philosophy. The idea is to add fixes and improvements little by little againstmasterbranch according to the (internally) assigned priorities.But the openSUSE conference is around the corner and there are few details we'd like to have more polished for the Agama in action and The future of Agama and openSUSE events.
Solution
Address some of these details as part of this PR. Go commit by commit to see them.
Testing
Note for reviewers
No changelog entry required.
Screenshots
Click to show/hide
Transactional root file system alert
TPM reminder look&feel
Acceptbutton when manually selecting the boot deviceSize unit selector
Related to https://trello.com/c/H3oZyzXS (internal link)