-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle language change in users and storage #1642
Conversation
Pull Request Test Coverage Report for Build 11069466549Details
💛 - Coveralls |
------------------------------------------------------------------- | ||
Fri Sep 27 09:23:40 UTC 2024 - Imobach Gonzalez Sosa <[email protected]> | ||
|
||
- Handle language change in users and storage (gh#agama-project/agama#1642). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NP: well ... instead of "language change" i'd use something like "switching UI language" ... to make obvious that the fix addresses switching of the language the UI uses instead of default EN
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
except one NP it LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LeBTM (= looks even better to me ;-)
Problem
Some parts of the UI are not properly translated (see #1629).
Solution
Properly refresh the issues in the users and storage services.
Testing