Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle language change in users and storage #1642

Merged
merged 5 commits into from
Sep 27, 2024
Merged

Conversation

imobachgs
Copy link
Contributor

Problem

Some parts of the UI are not properly translated (see #1629).

Solution

Properly refresh the issues in the users and storage services.

Testing

  • Tested manually

@coveralls
Copy link

coveralls commented Sep 27, 2024

Pull Request Test Coverage Report for Build 11069466549

Details

  • 12 of 16 (75.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+45.0%) to 70.441%

Changes Missing Coverage Covered Lines Changed/Added Lines %
service/lib/agama/manager.rb 0 1 0.0%
service/lib/agama/storage/manager.rb 0 1 0.0%
service/lib/agama/storage/proposal.rb 10 11 90.91%
service/lib/agama/with_locale.rb 0 1 0.0%
Totals Coverage Status
Change from base Build 11035679720: 45.0%
Covered Lines: 15633
Relevant Lines: 22193

💛 - Coveralls

-------------------------------------------------------------------
Fri Sep 27 09:23:40 UTC 2024 - Imobach Gonzalez Sosa <[email protected]>

- Handle language change in users and storage (gh#agama-project/agama#1642).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NP: well ... instead of "language change" i'd use something like "switching UI language" ... to make obvious that the fix addresses switching of the language the UI uses instead of default EN

Copy link
Contributor

@mchf mchf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

except one NP it LGTM

Copy link
Contributor

@mchf mchf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LeBTM (= looks even better to me ;-)

@imobachgs imobachgs merged commit c94f7d9 into master Sep 27, 2024
2 of 3 checks passed
@imobachgs imobachgs deleted the fix-language-change branch September 27, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants