Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rust): localize the keymaps descriptions #1643

Merged
merged 2 commits into from
Sep 27, 2024
Merged

fix(rust): localize the keymaps descriptions #1643

merged 2 commits into from
Sep 27, 2024

Conversation

imobachgs
Copy link
Contributor

Problem

Agama's UI always displays the keymaps descriptions in English.

Solution

Translate keymaps descriptions at API level.

Testing

  • Tested manually

@coveralls
Copy link

coveralls commented Sep 27, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11069721108

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 25.564%
Totals Coverage Status
Change from base Build 11035679720: 0.09%
Covered Lines: 1632
Relevant Lines: 6384
💛 - Coveralls

mchf
mchf approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@mchf mchf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imobachgs imobachgs merged commit e900505 into master Sep 27, 2024
1 check passed
@imobachgs imobachgs deleted the fix-keymaps-i18n branch September 27, 2024 11:46
This was referenced Sep 27, 2024
Closed
Merged
imobachgs added a commit that referenced this pull request Sep 27, 2024
@imobachgs
fix(web): fix localization of overview headers (#1645)
ded8adb 
## Problem

Related to #1629.

Overview headers are not translated.

## Solution

Do not call `_()` at module level (see #1643).

## Testing

- Tested manually
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchf mchf mchf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@imobachgs @coveralls @mchf