-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
storage: add config support for TPM FDE #1681
Merged
joseivanlopez
merged 6 commits into
agama-project:master
from
joseivanlopez:storage-missing-config
Oct 22, 2024
Merged
storage: add config support for TPM FDE #1681
joseivanlopez
merged 6 commits into
agama-project:master
from
joseivanlopez:storage-missing-config
Oct 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Do not pre-assign default values, otherwise it is impossible to know whether such values have to be solved.
joseivanlopez
force-pushed
the
storage-missing-config
branch
from
October 18, 2024 14:34
adf1dcf
to
ee02139
Compare
Pull Request Test Coverage Report for Build 11457735133Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
ancorgs
reviewed
Oct 22, 2024
joseivanlopez
force-pushed
the
storage-missing-config
branch
from
October 22, 2024 12:10
da49793
to
c11539f
Compare
joseivanlopez
changed the title
storage: add missing config properties
storage: add config support for TPM FDE
Oct 22, 2024
ancorgs
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the storage schema to allow selecting TPM FDE as encryption method and adapt config checker to complain if TPM FDE is selected but is not available.