Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added weblate-update-pot.yml GitHub Action #670

Merged
merged 3 commits into from
Jul 25, 2023
Merged

Added weblate-update-pot.yml GitHub Action #670

merged 3 commits into from
Jul 25, 2023

Conversation

lslezak
Copy link
Contributor

@lslezak lslezak commented Jul 19, 2023

Problem

Solution

  • Use a solution similar to the Cockpit solution
  • Run a GitHub Action regularly which generates the POT file and pushes it to the agama-weblate repository
  • To avoid unneeded commits the file is not updated when only the timestamp is changed and the rest of the file is the same

Notes

  • The xgettext call is just a temporary solution, it should be later replaced by some other call (Trello card)
  • Similarly the changes in the FileViewer.jsx file, these are there just to have some texts in the generated POT file and to have something to import to the Weblate

Testing

  • Tested manually
  • See this test run and a repeated test run (skipping the commit step because of no changes)
  • See the generated agama.pot file
  • At runtime the original English texts are displayed as the translations are currently not supported in the Web UI

@coveralls
Copy link

Coverage Status

coverage: 72.172% (+0.01%) from 72.16% when pulling a25b916 on lslezak:master into 410c673 on openSUSE:master.

- name: Generate POT file
# TODO: use a shared script for this
run: |
cd agama/web
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so if I get it, it generate pot file only from web part and not from service ( aka ruby code ) and from rust code?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, web frontend only. As noted in the TODO above, this should be replaced by some other script.

@lslezak lslezak merged commit 5d4f3b2 into agama-project:master Jul 25, 2023
7 checks passed
@imobachgs imobachgs mentioned this pull request Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants