Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run the Rubocop CI check only when a Ruby file is changed #694

Merged
merged 2 commits into from
Aug 9, 2023
Merged

Run the Rubocop CI check only when a Ruby file is changed #694

merged 2 commits into from
Aug 9, 2023

Conversation

lslezak
Copy link
Contributor

@lslezak lslezak commented Aug 9, 2023

Problem

  • The Rubocop check is run always, even when no Ruby file is modified
  • This makes CI slower and wastes some server resources

Solution

  • Put the Rubocop job into a separate file and use the path specifiers so it is run only when a matching file is updated

@lslezak
Run the Rubocop CI check only when a Ruby file is changed
d5c088f 
This avoids running Rubocop when it is not needed
@coveralls
Copy link

coveralls commented Aug 9, 2023 •
edited
Loading

Coverage Status

coverage: 72.134%. remained the same when pulling 766f3dd on ci-rubocop into 4df4c55 on master.

@lslezak lslezak merged commit e9bff87 into master Aug 9, 2023
12 checks passed
@lslezak lslezak deleted the ci-rubocop branch August 9, 2023 10:55
@imobachgs imobachgs mentioned this pull request Sep 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imobachgs imobachgs imobachgs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lslezak @coveralls @imobachgs