Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support table joins on key format mismatch #2

Closed
wants to merge 2 commits into from

Conversation

agavra
Copy link
Owner

@agavra agavra commented Dec 2, 2020

Description

fixes confluentinc#6229 and also remove the code around "required formats". This means that we will always chose the first "preferred" format using the algoirthm outlined in confluentinc#6393 but removing the restriction that tables are not re-partitioned. This still doesn't fully address what confluentinc#6017 (klip-33) outlines because it prefers the left instead of the right source to maintain some compatibility with previous code. It would be backwards compatible to change this as this is done at logical plan and not the physical plan.

Testing done

QTT testing

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant