-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Biconomy integration #277
Biconomy integration #277
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incredible!
/workflows/benchmarks agents/token/send,agents/token/test_swap.py 3 |
Finished benchmarks Test Run Summary
Detailed Results
Total run time: 16.15 minutes |
/workflows/benchmarks agents/token/test_swap_and_send.py 3 |
Finished benchmarks Test Run Summary
Detailed Results
Total run time: 8.44 minutes |
/workflows/benchmarks agents/token/research 3 |
Finished benchmarks Test Run Summary
Detailed Results
Total run time: 50.72 minutes |
@@ -41,5 +42,5 @@ def fetch_tokens_list() -> None: | |||
f.write(content) | |||
|
|||
|
|||
def run() -> None: | |||
fetch_tokens_list() | |||
async def run() -> None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there any reason to make this async? this is expected to be run through the script poetry run load-token
; I just tried it and got the error
autotx-py3.10cesar@dandy:~/dev/polywrap/auto-tx$ poetry run load-tokens
<coroutine object run at 0x7e0b30163d10>
sys:1: RuntimeWarning: coroutine 'run' was never awaited
RuntimeWarning: Enable tracemalloc to get the object allocation traceback
def on_intents_prepared(self, intents: list[Intent]) -> None: | ||
pass | ||
|
||
@abstractmethod |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: for abstract methods, I would recommend to raise an exception so if it is not implemented it will throw (even tho i think the build-check
script will complain about this)
})); | ||
|
||
app.post("/api/v1/account/transactions", handleError(async (req: Request, res: Response, next: NextFunction) => { | ||
const chainId = parseInt(req.query.chainId as string); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: should we validate that chainId
is indeed present in the query
object?
No description provided.