Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disclaimer: I did my best to explain the following issue and propose a fix. Don't hesitate to challenge this proposal or reject the pull request if not relevant.
Short description of the issue
Curve that contains multiple parts breaks the 2D plot with curve.
How to reproduce
Example of problematic curve
Let's say you have a LAS with NULL VALUE = -999, i.e. you can read in the LAS header:
NULL . -999.0000 : NULL VALUE
A problematic curve would be like:
Screenshot
Proposed fix
In
plot_2d_curve
only the first path returned byfill_betweenx
is considered to build thePathPatch
. As a result, the mask only covers the first portion of the curve. The rest is left blank. To fix the issue I just combined every paths into a singlePathPatch
object.