build: rename master branch to main branch [actions testing PR]
#2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- change GH Actions to use `main` branch in several branch checks
- and change GH issue templates to use `main` branch
- change scripts to use `main` branch
- change docs to use `main` branch
- also in many places we had absolute links instead of relative links
- docs convention is to use relative links where possible
- changing these to relative links meant that we no longer need to change the branch
- some docs also linked to the codebase when there's a page in the docs for it; relative link to the docs where appropriate
- change a few docs to use a permalink instead of a link to `master`
- Upgrading Notes and Proposals in particular linked to a specific line in a file, which is no longer the correct line
- fix the broken links with permalinks, since those docs are time-specific
- misc docs improvements while changing these lines
- use code backticks when referring to specific resource names, directories, etc, per [k8s style guide](https://kubernetes.io/docs/contribute/style/style-guide/#code-style-inline-code)
- prefer 1 sentence per line where the whole file didn't need changing
- add a few links to other docs where appropriate (e.g. when referencing environment variables)
- etc
- change a UI references (that linked to examples) to use the `main` branch
- and change one UI reference to link to the rendered docs website instead of the docs on `main`
Signed-off-by: Anton Gilgur <[email protected]>
- linked to a `blame` instead of the code view on GH accidentally; fixed Signed-off-by: Anton Gilgur <[email protected]>
|
All actions ran correctly as intended! There's just one lint error to fix (which will actually be fixed in a different way once I rebase to include the linter refactor/upgrade). Closing this testing PR out now -- see upstream argoproj#12149 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes argoproj#12127 -- this is a testing PR for argoproj#12149 per argoproj#12149 (review)
Motivation
Modifications
change GH Actions to use
mainbranch in several branch checksmainbranchchange scripts to use
mainbranchchange docs to use
mainbranchmasterargoproj/argoproj/masterto usemainas well, since per Rename the master branch to the main branch argoproj/argoproj#35 that repo's branch was already renamedchange UI references (that linked to examples) to use the
mainbranchmainVerification
make docsandmake codegenpassesUsing this very PR in my own fork for testing purposes.
Notes to Reviewers
We should rename the branch on GH before this is merged.
The branch rename functionality in GH will ensure that everything is redirected to the new branch name as well.