(hotfix): jsonify shouldn't set false to true #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- meant to use the previous code as an alternative to using a default
arg, but `!jsonify` detects false (etc), not just undefined
- switched to just using a default arg, which was what I originally
used before moving defaults outside of the destructuring
- alternative is to check `typeof jsonify === 'undefined'` instead
- default args seem to provide better typings in my experience, so
stick to that for now
This was referenced Nov 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
arg, but
!jsonifydetects false (etc), not just undefinedused before moving defaults outside of the destructuring
typeof jsonify === 'undefined'insteadstick to that for now
Fixes #17 . Would really like to get #4 done before releasing this for that extra confidence that it actually works though.