Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): race- and timeout-free -bblock #423

Draft
wants to merge 1 commit into
base: Agoric
Choose a base branch
from

Conversation

michaelfig
Copy link
Collaborator

@michaelfig michaelfig commented Aug 5, 2024

Description

The old -bblock relied on CometBFT's /tx_broadcast_commit endpoint, with its arbitrary, implicit 30 second timeout for block inclusion. This PR reimplements the tx -bblock flag with a subscribe(txhash)-broadcast(sync)-wait(txhash-inclusion), with no timeout.

It would be interesting to make this more robust, and offer the mechanism as a new CLI command (agd query wait-for ... ?), as well as a flag (--wait-for=<condition> ?) added to all agd tx ... and agd query tx ....

The idea would be to give power to calling scripts using the default -bsync to obtain the txHash, then code their own timeouts and/or retry loops.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@michaelfig michaelfig self-assigned this Aug 5, 2024
@github-actions github-actions bot added the C:CLI label Aug 5, 2024
@michaelfig
Copy link
Collaborator Author

@JeancarloBarrios do you know of some prior art in Cosmos-SDK to provide similar functionality?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants