-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testnet GC, metering #5
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I read ahead in Agoric/agoric-sdk#3023 to understand these fields. I don’t see anything wrong. I like that you can use the sum of Add+Remove for operations and the difference Add-Remove for memory.
xs/sources/xsMapSet.c
Outdated
@@ -1034,6 +1034,9 @@ txBoolean fxDeleteEntry(txMachine* the, txSlot* table, txSlot* list, txSlot* key | |||
address = &slot->next; | |||
} | |||
} | |||
#ifdef __XSNAP__ | |||
the->mapSetRemoveCount += 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like spaces instead of tabs here on Github. The indent doesn’t align.
@@ -428,7 +428,7 @@ void fxGrowChunks(txMachine* the, txSize theSize) | |||
if (!(the->collectFlag & XS_SKIPPED_COLLECT_FLAG)) { | |||
txSize modulo = theSize % the->minimumChunksSize; | |||
if (modulo) | |||
fxAddChunkSizes(the, theSize, the->minimumChunksSize - modulo); | |||
theSize = fxAddChunkSizes(the, theSize, the->minimumChunksSize - modulo); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, good catch.
cc @warner